Conversation
|
|
||
| trait PersistenceTokenTrait | ||
| { | ||
| protected TokenRepository $tokenRepository; |
Contributor
There was a problem hiding this comment.
is necessary? this property is defined in another class...
Contributor
Author
There was a problem hiding this comment.
Helps IDE to find the $tokenRepository type and definition
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Solution
This PR refactors the callProcess function to use the Nayra BPMN engine. This improves reliability, enables process calls by ID using a CallProcess event, and includes thorough testing for error handling.
How to Test
Run a process with SubProcesses. (See the attached file)
Scenario 1
Scenario 2
Related Tickets & Packages
Code Review Checklist